Change in vdsm[master]: Introduce commands module to separate execCmd and AsyncProc ...

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Mon Jan 11 08:08:17 UTC 2016


Piotr Kliczewski has posted comments on this change.

Change subject: Introduce commands module to separate execCmd and AsyncProc from utils
......................................................................


Patch Set 11: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/51421/11/lib/vdsm/host.py
File lib/vdsm/host.py:

Line 24: from . import constants
Line 25: 
Line 26: __hostUUID = None
Line 27: 
Line 28: 
It is great idea to split utils module further but I do not see anything about this module in commit message about it.

It should be done in separate patch.
Line 29: def uuid(legacy=False):
Line 30:     global __hostUUID
Line 31: 
Line 32:     if legacy:


-- 
To view, visit https://gerrit.ovirt.org/51421
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I295f5516154c464fe5b1fc103b7b9d1d76dffe17
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list