Change in vdsm[ovirt-3.6]: Return correct scan alignment result through jsonrpc

tnisan at redhat.com tnisan at redhat.com
Sun Jan 10 18:58:13 UTC 2016


Tal Nisan has uploaded a new change for review.

Change subject: Return correct scan alignment result through jsonrpc
......................................................................

Return correct scan alignment result through jsonrpc

Since jsonrpc was introduced in oVirt 3.5 the scan alignment verb returned
the default value in jsonrpc mode which is "true" regardless to the actual
result, this was fixed in this patch

Change-Id: If9ace1a9596f13225e493eda090d69a82d7c2bc1
Signed-off-by: Tal Nisan <tnisan at redhat.com>
Bug-Url: https://bugzilla.redhat.com/1294823
---
M vdsm/rpc/Bridge.py
M vdsm/rpc/vdsmapi-schema.json
2 files changed, 17 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/51613/1

diff --git a/vdsm/rpc/Bridge.py b/vdsm/rpc/Bridge.py
index 9765387..319ec3c 100644
--- a/vdsm/rpc/Bridge.py
+++ b/vdsm/rpc/Bridge.py
@@ -464,6 +464,7 @@
     'VM_create': {'ret': 'vmList'},
     'VM_cont': {'ret': VM_running_state_change_Ret},
     'VM_diskSizeExtend': {'ret': 'size'},
+    'VM_getDiskAlignment': {'ret': 'alignment'},
     'VM_getInfo': {'call': VM_getInfo_Call, 'ret': VM_getInfo_Ret},
     'VM_getIoTunePolicy': {'ret': 'ioTunePolicyList'},
     'VM_getStats': {'ret': 'statsList'},
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index 770434e..fab6145 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -8068,18 +8068,32 @@
           'dstDisk': 'DriveSpecVolume'}}
 
 ##
+# @DiskAlignmentMap:
+#
+# A map of the disk alignment from partition name to whether it's aligned
+#
+# Since: 4.17.17
+##
+{'map': 'DiskAlignmentMap',
+ 'key': 'str', 'value': 'bool'}
+
+##
 # @VM.getDiskAlignment:
 #
-# Returns the alignment of the disk partitions.
+# Check alignment of virtual machine disk partitions.
 #
 # @vmID:     The UUID of the VM
 #
 # @disk:  A @DriveSpecVolume structure rapresenting the disk
 #
+# Returns:
+# Mapping of partition name to alignment status (new in version 4.17.17)
+#
 # Since: 4.11.0
 ##
 {'command': {'class': 'VM', 'name': 'getDiskAlignment'},
- 'data': {'vmID': 'UUID', 'disk': 'DriveSpecVolume'}}
+ 'data': {'vmID': 'UUID', 'disk': 'DriveSpecVolume'},
+ 'returns': 'DiskAlignmentMap'}
 
 ##
 # @VM.diskSizeExtend:


-- 
To view, visit https://gerrit.ovirt.org/51613
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If9ace1a9596f13225e493eda090d69a82d7c2bc1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>


More information about the vdsm-patches mailing list