Change in vdsm[master]: Return correct scan alignment result through jsonrpc

nsoffer at redhat.com nsoffer at redhat.com
Sun Jan 10 16:48:30 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: Return correct scan alignment result through jsonrpc
......................................................................


Patch Set 2:

(5 comments)

https://gerrit.ovirt.org/#/c/51607/2//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2016-01-10 18:08:24 +0200
Line 4: Commit:     Tal Nisan <tnisan at redhat.com>
Line 5: CommitDate: 2016-01-10 18:08:24 +0200
Line 6: 
Line 7: Return correct scan alignment result through jsonrpc
Add a note about incorrect schema, causing this verb to broken when using jsonrpc since 3.5.
Line 8: 
Line 9: Change-Id: If9ace1a9596f13225e493eda090d69a82d7c2bc1
Line 10: Signed-off-by: Tal Nisan <tnisan at redhat.com>


Line 7: Return correct scan alignment result through jsonrpc
Line 8: 
Line 9: Change-Id: If9ace1a9596f13225e493eda090d69a82d7c2bc1
Line 10: Signed-off-by: Tal Nisan <tnisan at redhat.com>
Line 11: Bug-Url: https://bugzilla.redhat.com/1294823
This is an engine bug, please fix the bug.


https://gerrit.ovirt.org/#/c/51607/2/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:

Line 8134
Line 8135
Line 8136
Line 8137
Line 8138
Add:

    Returns:
    Mapping of partition name to alignment status
    (new in version 4.17)


Line 8127:  'data': {'vmID': 'UUID', 'srcDisk': 'DriveSpecVolume',
Line 8128:           'dstDisk': 'DriveSpecVolume'}}
Line 8129: 
Line 8130: ##
Line 8131: # @DiskAlignmentResultMap:
Little too long, how about DiskAlignmentMap?
Line 8132: #
Line 8133: # A map of the disk alignment from partition name to whether it's aligned
Line 8134: #
Line 8135: # Since: 4.10.0


Line 8131: # @DiskAlignmentResultMap:
Line 8132: #
Line 8133: # A map of the disk alignment from partition name to whether it's aligned
Line 8134: #
Line 8135: # Since: 4.10.0
Since 4.17. The schema describe *only* the jsonrpc interface. xmlrpc is not compatible with the schema.
Line 8136: ##
Line 8137: {'map': 'DiskAlignmentResultMap',
Line 8138:  'key': 'str', 'value': 'bool'}
Line 8139: 


-- 
To view, visit https://gerrit.ovirt.org/51607
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9ace1a9596f13225e493eda090d69a82d7c2bc1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list