Change in vdsm[master]: net tests: Skip dump_bonding_name2numeric on EBUSY

edwardh at redhat.com edwardh at redhat.com
Sun Jan 10 16:44:59 UTC 2016


Edward Haas has posted comments on this change.

Change subject: net tests: Skip dump_bonding_name2numeric on EBUSY
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/51412/1/tests/toolBondingTests.py
File tests/toolBondingTests.py:

Line 17: # Refer to the README and COPYING files for full details of the license
Line 18: #
Line 19: 
Line 20: 
Line 21: import errno
> please lump all stdlib import (errno and os) up here.
Done
Line 22: from vdsm.tool.dump_bonding_opts \
Line 23:     import _get_bonding_options_name2numeric
Line 24: from os import uname
Line 25: from testlib import VdsmTestCase as TestCaseBase


Line 20: 
Line 21: import errno
Line 22: from vdsm.tool.dump_bonding_opts \
Line 23:     import _get_bonding_options_name2numeric
Line 24: from os import uname
> Please avoid such imports, there is no reason to not to use os.uname().
Done
Line 25: from testlib import VdsmTestCase as TestCaseBase
Line 26: from testValidation import ValidateRunningAsRoot
Line 27: from modprobe import RequireBondingMod
Line 28: from nose.plugins.skip import SkipTest


-- 
To view, visit https://gerrit.ovirt.org/51412
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifecaacf7f0df6e490bafc7908c4519ca9a12b450
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list