Change in vdsm[master]: net: Remove the defaultGateway api canonization

edwardh at redhat.com edwardh at redhat.com
Sun Jan 10 13:54:45 UTC 2016


Edward Haas has uploaded a new change for review.

Change subject: net: Remove the defaultGateway api canonization
......................................................................

net: Remove the defaultGateway api canonization

Previous versions (<3.6) have allowed the management network to be set
without defaultGateway=True from the API.  For the management network,
VDSM has canonized defaultGateway to True if the flag was missing.

>From 3.6, defaultGateway is set explicitly by Engine and there is no
longer a need to canonize the value.

Change-Id: Ib6a062687fe39352fa49cbe7bd446e8d3cfa0c27
Signed-off-by: Edward Haas <edwardh at redhat.com>
---
M lib/vdsm/network/api.py
1 file changed, 0 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/51596/1

diff --git a/lib/vdsm/network/api.py b/lib/vdsm/network/api.py
index 893e2d6..7e94ac9 100755
--- a/lib/vdsm/network/api.py
+++ b/lib/vdsm/network/api.py
@@ -284,13 +284,6 @@
         for nic in nics:
             _validateInterNetworkCompatibility(_netinfo, vlan, nic)
 
-    # defaultRoute is set either explicitly by the client, OR if we're adding
-    # the management network.
-    # REQUIRED_FOR: clusterLevel<=3.3
-    #       remove reference to constants.LEGACY_MANAGEMENT_NETWORKS
-    if defaultRoute is None:
-        defaultRoute = network in constants.LEGACY_MANAGEMENT_NETWORKS
-
     logging.info("Adding network %s with vlan=%s, bonding=%s, nics=%s,"
                  " bondingOptions=%s, mtu=%s, bridged=%s, defaultRoute=%s,"
                  "options=%s", network, vlan, bonding, nics, bondingOptions,


-- 
To view, visit https://gerrit.ovirt.org/51596
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib6a062687fe39352fa49cbe7bd446e8d3cfa0c27
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>


More information about the vdsm-patches mailing list