Change in vdsm[master]: v2v: support for importing Xen VMs via libvirt on RHEL hosts

nsoffer at redhat.com nsoffer at redhat.com
Sun Jan 10 11:53:33 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: v2v: support for importing Xen VMs via libvirt on RHEL hosts
......................................................................


Patch Set 11:

(1 comment)

https://gerrit.ovirt.org/#/c/49505/11/vdsm/v2v.py
File vdsm/v2v.py:

Line 288:             raise
Line 289:         raise NoSuchOvf("No such ovf %r" % file_name)
Line 290: 
Line 291: 
Line 292: class SSHAgent(object):
> non need to fake ssh-add, its fast and works well with the real ssh-add
We cannot run the real ssh-add and ssh-agent in the unit test. We are testing our code, on a developer machine, this is not a system test.
Line 293:     def __init__(self):
Line 294:         self._auth = None
Line 295:         self._ssh_agend_pid = None
Line 296:         self._ssh_auth_re = re.compile(_SSH_AUTH_RE)


-- 
To view, visit https://gerrit.ovirt.org/49505
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If544c0247003b6bc7189f72130553b9402dc915d
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list