Change in vdsm[master]: v2v: support for importing Xen VMs via libvirt on RHEL hosts

shavivi at redhat.com shavivi at redhat.com
Sun Jan 10 11:41:40 UTC 2016


Shahar Havivi has posted comments on this change.

Change subject: v2v: support for importing Xen VMs via libvirt on RHEL hosts
......................................................................


Patch Set 11:

(3 comments)

https://gerrit.ovirt.org/#/c/49505/11/vdsm/v2v.py
File vdsm/v2v.py:

Line 174:     _add_job(job_id, job)
Line 175:     return response.success()
Line 176: 
Line 177: 
Line 178: def convert_xen_vm(uri, vminfo, job_id, irs):
> Needs a test
Done
Line 179:     command = XenCommand(uri, vminfo, job_id, irs)
Line 180:     job = ImportVm(job_id, command)
Line 181:     job.start()
Line 182:     _add_job(job_id, job)


Line 288:             raise
Line 289:         raise NoSuchOvf("No such ovf %r" % file_name)
Line 290: 
Line 291: 
Line 292: class SSHAgent(object):
> Needs tests, probably by faking both ssh-agent and ssh-add
non need to fake ssh-add, its fast and works well with the real ssh-add
Line 293:     def __init__(self):
Line 294:         self._auth = None
Line 295:         self._ssh_agend_pid = None
Line 296:         self._ssh_auth_re = re.compile(_SSH_AUTH_RE)


Line 501:         with self._volumes():
Line 502:             yield self._start_virt_v2v()
Line 503: 
Line 504: 
Line 505: class XenCommand(V2VCommand):
> Needs tests - can be tested like convert_external_vm with a fake-virt-v2v.
Done
Line 506:     def __init__(self, uri, vminfo, job_id, irs):
Line 507:         super(XenCommand, self).__init__(vminfo, job_id, irs)
Line 508:         self._uri = uri
Line 509:         self._ssh_agent = SSHAgent()


-- 
To view, visit https://gerrit.ovirt.org/49505
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If544c0247003b6bc7189f72130553b9402dc915d
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list