Change in vdsm[master]: Introduce commands package to separate execCmd and AsyncProc...

nsoffer at redhat.com nsoffer at redhat.com
Fri Jan 8 19:02:38 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: Introduce commands package to separate execCmd and AsyncProc from utils
......................................................................


Patch Set 9:

(1 comment)

https://gerrit.ovirt.org/#/c/51421/9//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2016-01-08 20:02:01 +0200
Line 6: 
Line 7: Introduce commands package to separate execCmd and AsyncProc from utils
Line 8: 
Line 9: Those two classes requires cpopen and StringIO which are not available
stwo classes -> tow

execCmd is not a class
Line 10: in python3. utils.py should be splited to sub packages anyway, and this work
Line 11: not only provides the ability to import utils.py with python3, but also
Line 12: start the work of splitting utils.py to meaningful packages.
Line 13: 


-- 
To view, visit https://gerrit.ovirt.org/51421
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I295f5516154c464fe5b1fc103b7b9d1d76dffe17
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list