Change in vdsm[master]: virt: Don't expose GuestAgent.guestInfo directly

mzamazal at redhat.com mzamazal at redhat.com
Fri Jan 8 14:27:03 UTC 2016


Milan Zamazal has posted comments on this change.

Change subject: virt: Don't expose GuestAgent.guestInfo directly
......................................................................


Patch Set 3:

We discussed that with Vinzenz extensively and we decided making a shallow copy instead of a deep copy is probably a reasonable compromise.  While it doesn't prevent modification of mutable values of the dictionary, still:

- It fixes the bug.
- It is better than it was before.
- It doesn't cause performance hit with large values such as the list of installed packages.
- The dictionary values should be of immutable types after all, if possible.

Other solutions we could think of are either too wild or don't prevent future bugs of the same kind.

So is using shallow copy fine for you, Francesco?

-- 
To view, visit https://gerrit.ovirt.org/51508
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie48c697300e4feeb513dc662c2d1d3d8c21f0af9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list