Change in vdsm[master]: untested: notify Engine when host connectivity changes

fromani at redhat.com fromani at redhat.com
Fri Jan 8 14:26:47 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: untested: notify Engine when host connectivity changes
......................................................................


Patch Set 1:

(1 comment)

conceptually I'm fine with the idea, but it needs some polishing.

https://gerrit.ovirt.org/#/c/51135/1/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:

Line 556:         else:
Line 557:             diff = sample.connlog_diff(second_last)
Line 558:             if diff:
Line 559:                 self._CONNLOG.debug('%s', diff)
Line 560:                 if self._cif is not None:
If you prefer, feel free to change the signature of __init__ to make cif required.
Line 561:                     self._cif.notify('|net|host_conn|')
Line 562: 
Line 563: 
Line 564: def _getLinkSpeed(dev):


-- 
To view, visit https://gerrit.ovirt.org/51135
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e2df34c95709a3e201e984909dcb78c97c20710
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list