Change in vdsm[master]: Introduce commands package to separate execCmd and AsyncProc...

fromani at redhat.com fromani at redhat.com
Fri Jan 8 14:24:51 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: Introduce commands package to separate execCmd and AsyncProc from utils
......................................................................


Patch Set 4:

kudos for the effort!
Unfortunately this is huge from every possible way we can consider. Please try to make it smaller somehow. At first glance it seems indeed you are moving too much code -at least for this change.
Removing unnecessary changes can haelp reducing the size of this patch.

-- 
To view, visit https://gerrit.ovirt.org/51421
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I295f5516154c464fe5b1fc103b7b9d1d76dffe17
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list