Change in vdsm[master]: virt: Don't expose GuestAgent.guestInfo directly

vfeenstr at redhat.com vfeenstr at redhat.com
Fri Jan 8 13:08:51 UTC 2016


Vinzenz Feenstra has posted comments on this change.

Change subject: virt: Don't expose GuestAgent.guestInfo directly
......................................................................


Patch Set 3:

We should consider that copying guestInfo might contain quite a lot of data (e.g. Windows VMs report all installed applications when the guest agent is installed, which can be a quite extensive list)
If there are many VMs (hundreds...) then there's a highrisk that this operation can be very slow.

I don't want to block this fix from it - because technically I kind of agree with the solution however I hesitate to give a +1 for it due to aforementioned reason

-- 
To view, visit https://gerrit.ovirt.org/51508
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie48c697300e4feeb513dc662c2d1d3d8c21f0af9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list