Change in vdsm[master]: exception: Add exceptions for vdsm.define errors

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Fri Jan 8 10:43:37 UTC 2016


Piotr Kliczewski has posted comments on this change.

Change subject: exception: Add exceptions for vdsm.define errors
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

The codes are part of the contract between the engine and vdsm. We need to make sure that they are aligned on both ends. Please check org.ovirt.engine.core.common.errors.EngineError for all the codes there are.

We need to make sure that we have common copy of the codes between the engine and vdsm. It doesn't make sense to keep them on both sides.

https://gerrit.ovirt.org/#/c/48871/5/lib/vdsm/exception.py
File lib/vdsm/exception.py:

Line 35:     code = 1
Line 36:     message = 'Virtual machine does not exist'
Line 37: 
Line 38: 
Line 39: # TODO: check if we can reuse code=2
We can reuse 2. It is not used on the engine side.
Line 40: 
Line 41: 
Line 42: class AccessTimeout(VdsmException):
Line 43:     code = 3


-- 
To view, visit https://gerrit.ovirt.org/48871
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01b736c06414a3af758ad6bdabddb6c25b620756
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list