Change in vdsm[master]: exception: Make VdsmException reusable

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Thu Jan 7 16:35:22 UTC 2016


Piotr Kliczewski has posted comments on this change.

Change subject: exception: Make VdsmException reusable
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

Based on comment changing the score.

https://gerrit.ovirt.org/#/c/48875/2/tests/exception_test.py
File tests/exception_test.py:

Line 19: #
Line 20: 
Line 21: from testlib import VdsmTestCase
Line 22: from vdsm.exception import VdsmException
Line 23: 
> GlusterException should have tests in the gluster package, I cannot test he
OK. We need to make sure that the test module for gluster is created.
Line 24: 
Line 25: class SubExceptiong(VdsmException):
Line 26:     code = 42
Line 27:     message = "message"


-- 
To view, visit https://gerrit.ovirt.org/48875
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd6643d9670cb9b067e372bf5a1a6c57ced41954
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list