Change in vdsm[master]: sp: update domain links on state change

nsoffer at redhat.com nsoffer at redhat.com
Thu Jan 7 15:33:34 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: sp: update domain links on state change
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/27334/4/vdsm/storage/sp.py
File vdsm/storage/sp.py:

Line 140:         return self._backend
Line 141: 
Line 142:     @unsecured
Line 143:     def _domainStateChange(self, sdUUID, isValid):
Line 144:         if isValid and sdUUID in self.getDomains():
> I know that this was merged to 3.4, but what will happen when domain is dea
Good catch - Idan, can you fix this in the following patch?

The next patch is fixing lot of issue in this one, we kept them separate since this patch was already merged in 3.4.
Line 145:             self._refreshDomainLinks(sdCache.produce(sdUUID))
Line 146: 
Line 147:     def _upgradePoolDomain(self, sdUUID, isValid):
Line 148:         # This method is called everytime the onDomainStateChange


-- 
To view, visit https://gerrit.ovirt.org/27334
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ac20e4b515472b24c35b2cccd2ad3dc98b3574c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Xavi Francisco <xfrancis at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list