Change in vdsm[master]: vdsm: introduce cpuinfo module

fromani at redhat.com fromani at redhat.com
Thu Jan 7 14:21:14 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: vdsm: introduce cpuinfo module
......................................................................


Patch Set 20: Code-Review-1

(2 comments)

Partial review. It seems we miss some debian packaging bits, so -1 for visibility

https://gerrit.ovirt.org/#/c/46912/20/debian/vdsm-tests.install
File debian/vdsm-tests.install:

Line 9: usr/share/vdsm/tests/caps_libvirt_intel_i73770_nosnap.out
Line 10: usr/share/vsdm/tests/caps_numactl_4_nodes.out
Line 11: usr/share/vdsm/tests/cpu_info.out
Line 12: usr/share/vdsm/tests/cpu_map.xml
Line 13: usr/share/vdsm/tests/cpuinfo/*.out
don't we need to add cpuarch.py in debian package list as well?
Line 14: usr/share/vdsm/tests/devices/parsing*.py
Line 15: usr/share/vdsm/tests/devices/data/*.xml
Line 16: usr/share/vdsm/tests/functional/*.policy
Line 17: usr/share/vdsm/tests/functional/*.py


https://gerrit.ovirt.org/#/c/46912/20/lib/vdsm/cpuinfo.py
File lib/vdsm/cpuinfo.py:

Line 28: _SOURCE = '/proc/cpuinfo'
Line 29: 
Line 30: 
Line 31: @utils.memoized
Line 32: def parse(source=_SOURCE):
> OK, maybe add a TODO for this?
+1 for TODO
Line 33:     '''
Line 34:     Parse cpuinfo-like file, keeping the values in module's runtime variables.
Line 35: 
Line 36:     Arguments:


-- 
To view, visit https://gerrit.ovirt.org/46912
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa702b05f3825ebdcfed16d86d39a8c38fcf224c
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list