Change in vdsm[master]: virt: Don't expose GuestAgent.guestInfo directly

mzamazal at redhat.com mzamazal at redhat.com
Thu Jan 7 14:05:08 UTC 2016


Milan Zamazal has posted comments on this change.

Change subject: virt: Don't expose GuestAgent.guestInfo directly
......................................................................


Patch Set 1:

(1 comment)

Commit message improved.

https://gerrit.ovirt.org/#/c/51508/1/vdsm/virt/guestagent.py
File vdsm/virt/guestagent.py:

Line 357:         return self.guestStatus
Line 358: 
Line 359:     def getGuestInfo(self):
Line 360:         if self.isResponsive():
Line 361:             return copy.copy(self.guestInfo)
> is a shallow copy sufficient? if so let's have a comment stating this. Or, 
Thanks for the hint about picklecopy. Done.
Line 362:         else:
Line 363:             return {
Line 364:                 'username': 'Unknown',
Line 365:                 'session': 'Unknown',


-- 
To view, visit https://gerrit.ovirt.org/51508
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie48c697300e4feeb513dc662c2d1d3d8c21f0af9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list