Change in vdsm[master]: virt: Handle fork() related issues in vmchannels/guestagent
mpolednik at redhat.com
mpolednik at redhat.com
Thu Jan 7 13:41:01 UTC 2016
Martin Polednik has posted comments on this change.
Change subject: virt: Handle fork() related issues in vmchannels/guestagent
......................................................................
Patch Set 14: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/42570/14/vdsm/virt/guestagent.py
File vdsm/virt/guestagent.py:
Line 210: filecontrol.set_close_on_exec(sock.fileno())
Line 211: sock.setblocking(0)
Line 212: return sock
Line 213:
Line 214: @staticmethod
should be normal method
Line 215: def _create(self):
Line 216: self._sock.close()
Line 217: self._sock = self._create_socket()
Line 218: return self._sock.fileno()
--
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer%redhat.com at gtempaccount.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list