Change in vdsm[master]: sp: update domain links on state change

nsoffer at redhat.com nsoffer at redhat.com
Thu Jan 7 12:57:34 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: sp: update domain links on state change
......................................................................


Patch Set 4: Code-Review+1

This is a minimal change, but we have few issues:

- On each connectToPool, we are leaking the old _domainStateChange registration
- We register for events before they can be delivered
- We never unregister, possibly getting events when we should not handle them (e.g. old pool object handling event while another pool is active).
- No locking when accessing pool state
- No locking when refreshing links, possibly harming non-thread safe parts of vdsm (lvm.py),or failing the request when 2 threads are checking and creating symlinks.

These issues are fixed in the next patch.

-- 
To view, visit https://gerrit.ovirt.org/27334
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ac20e4b515472b24c35b2cccd2ad3dc98b3574c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Xavi Francisco <xfrancis at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list