Change in vdsm[master]: Introduce execproc package to separate execCmd and AsyncProc...

nsoffer at redhat.com nsoffer at redhat.com
Wed Jan 6 20:36:08 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: Introduce execproc package to separate execCmd and AsyncProc from utils
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/51421/2//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: Those two classes requires cpopen and StringIO which are not available
Line 10: in python3. utils.py should be splited to sub packages anyway, and this work
Line 11: not only provides the ability to import utils.py with python3, but also
Line 12: start the work of splitting utils.py to meaningful packages.
This change does not help to import utils.py, since you import execproc in utils.py.

The change we need is to move all code related to running sub processes out of utils, so code that need other utilities can import utils in Python 3.
Line 13: 
Line 14: Change-Id: I295f5516154c464fe5b1fc103b7b9d1d76dffe17


-- 
To view, visit https://gerrit.ovirt.org/51421
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I295f5516154c464fe5b1fc103b7b9d1d76dffe17
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list