Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

nsoffer at redhat.com nsoffer at redhat.com
Wed Jan 6 14:28:17 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
......................................................................


Patch Set 15:

(1 comment)

https://gerrit.ovirt.org/#/c/44045/15/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 533:         cls.createMetadata(metaId, meta_dict)
Line 534:         return meta_dict
Line 535: 
Line 536:     @classmethod
Line 537:     def new_metadata_dict(cls, sdUUID, imgUUID, puuid, size, format, type,
> We need a better name than VolumeMeta.  What's the difference between Volum
I agree, VolumeMetadata would be great, but you took that name :-)
Line 538:                           voltype, disktype, desc="", legality=ILLEGAL_VOL):
Line 539:         """
Line 540:         Produce a metadata dictionary from a set of arguments.
Line 541:         """


-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list