Change in vdsm[master]: vdsm: introduce cpuinfo module

nsoffer at redhat.com nsoffer at redhat.com
Wed Jan 6 14:03:36 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: vdsm: introduce cpuinfo module
......................................................................


Patch Set 20:

(1 comment)

https://gerrit.ovirt.org/#/c/46912/20/lib/vdsm/cpuinfo.py
File lib/vdsm/cpuinfo.py:

Line 28: _SOURCE = '/proc/cpuinfo'
Line 29: 
Line 30: 
Line 31: @utils.memoized
Line 32: def parse(source=_SOURCE):
Why parse the entire file when we are interested only in the first entry?

Why not use regex to get he interesting fields?
Line 33:     '''
Line 34:     Parse cpuinfo-like file, keeping the values in module's runtime variables.
Line 35: 
Line 36:     Arguments:


-- 
To view, visit https://gerrit.ovirt.org/46912
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa702b05f3825ebdcfed16d86d39a8c38fcf224c
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list