Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

shavivi at redhat.com shavivi at redhat.com
Wed Jan 6 12:42:40 UTC 2016


Shahar Havivi has posted comments on this change.

Change subject: v2v: externalVMList Xen+Kvm support
......................................................................


Patch Set 25:

(1 comment)

https://gerrit.ovirt.org/#/c/48672/25/tests/v2vTests.py
File tests/v2vTests.py:

Line 133:         for vm in self._vms:
Line 134:             if vm.name == name:
Line 135:                 return vm
Line 136:         raise fake.Error(libvirt.VIR_ERR_NO_DOMAIN,
Line 137:                          'virDomainLookupByName() failed')
> Do we have tests using this?
test for what, the test?
Line 138: 
Line 139:     def lookupByID(self, id):
Line 140:         for vm in self._vms:
Line 141:             if vm.id == id:


-- 
To view, visit https://gerrit.ovirt.org/48672
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7d7e211a9343a528f260da2686b34cea00c53a4
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eric Blake <eblake at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list