Change in vdsm[master]: sp: improve domainStateChange event handling

nsoffer at redhat.com nsoffer at redhat.com
Wed Jan 6 10:05:22 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: sp: improve domainStateChange event handling
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/51393/3//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: onDomainStateChange is registered in the constructor of StoragePool.
Line 10: This is a waste of resources since these events can be called only after
Line 11: the connect method is called (specifically, after __rebuild is called
Line 12: from within connect).
> The main issue (leaking registration) is non-issue, multiple registration r
Correction - the main issue is an issue - we do a new registeration for each new pool object, so we do leak one registration for each new pool connect as I wrote before.
Line 13: 
Line 14: This patch moves the registration to onDomainStateChange to be right
Line 15: before it can actually be called (in connect), and calls unregister if
Line 16: an error has occurred in __rebuild.


-- 
To view, visit https://gerrit.ovirt.org/51393
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If116100d3ae967f6a5490a2d91bf923e953cb4ee
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list