Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

nsoffer at redhat.com nsoffer at redhat.com
Wed Jan 6 09:34:26 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: v2v: externalVMList Xen+Kvm support
......................................................................


Patch Set 25: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/48672/25/vdsm/v2v.py
File vdsm/v2v.py:

Line 646:         for vm in conn.listAllDomains():
Line 647:             yield vm
Line 648:     # TODO: use only the new API (no need to fall back to listDefinedDomains)
Line 649:     #       when supported in Xen under RHEL 5.x
Line 650:     except libvirt.libvirtError as e:
Look in the coverage report - this code has no test. New code must have 100% coverage.
Line 651:         if e.get_error_code() != libvirt.VIR_ERR_NO_SUPPORT:
Line 652:             raise
Line 653:         # Support for old libvirt clients
Line 654:         seen = set()


-- 
To view, visit https://gerrit.ovirt.org/48672
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7d7e211a9343a528f260da2686b34cea00c53a4
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eric Blake <eblake at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list