Change in vdsm[master]: guest-agent: desktopLock exception on EBADF should be ignored

nsoffer at redhat.com nsoffer at redhat.com
Wed Jan 6 08:49:48 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: guest-agent: desktopLock exception on EBADF should be ignored
......................................................................


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/47404/8/vdsm/virt/guestagent.py
File vdsm/virt/guestagent.py:

Line 374:             self.log.debug("desktopLock called")
Line 375:             self._forward("lock-screen")
Line 376:         except Exception as e:
Line 377:             if isinstance(e, socket.error) and e.args[0] == errno.EBADF:
Line 378:                 return  # Expected when not connected/closed socket
I like to have debug log in this case, something like "Socket is not connected". It seems that we get only one event now in 7.2, so it is not going to be an issue.
Line 379:             self.log.exception("desktopLock failed with unexpected exception")
Line 380: 
Line 381:     def desktopLogin(self, domain, user, password):
Line 382:         try:


-- 
To view, visit https://gerrit.ovirt.org/47404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cd032471396a97999c2cea5c88ae04ec8ca4028
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list