Change in vdsm[master]: sp: update domain links on state change
ishaby at redhat.com
ishaby at redhat.com
Wed Jan 6 07:07:26 UTC 2016
Idan Shaby has posted comments on this change.
Change subject: sp: update domain links on state change
......................................................................
Patch Set 3:
(2 comments)
Please also review https://gerrit.ovirt.org/#/c/51393/ .
https://gerrit.ovirt.org/#/c/27334/3/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line 94: proxy(self))
Line 95: self._domainStateCallback = partial(
Line 96: StoragePool._domainStateChange, proxy(self))
Line 97: self.domainMonitor.onDomainStateChange.register(
Line 98: self._domainStateCallback)
> This does not look right, the pool should not process any event while it is
Please see https://gerrit.ovirt.org/#/c/51393/ .
Line 99: self._backend = None
Line 100:
Line 101: def __is_secure__(self):
Line 102: return self.isSecure()
Line 139: def getBackend(self):
Line 140: return self._backend
Line 141:
Line 142: def _domainStateChange(self, sdUUID, isValid):
Line 143: if isValid and sdUUID in self.getDomains():
> We need to change this to use the early return style as in _upgradePoolDoma
Please see https://gerrit.ovirt.org/#/c/51393/ .
Line 144: self._refreshDomainLinks(sdCache.produce(sdUUID))
Line 145:
Line 146: def _upgradePoolDomain(self, sdUUID, isValid):
Line 147: # This method is called everytime the onDomainStateChange
--
To view, visit https://gerrit.ovirt.org/27334
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ac20e4b515472b24c35b2cccd2ad3dc98b3574c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Xavi Francisco <xfrancis at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list