Change in vdsm[master]: VolumeMetadata: Add getParentVolume

alitke at redhat.com alitke at redhat.com
Tue Jan 5 18:44:24 UTC 2016


Adam Litke has posted comments on this change.

Change subject: VolumeMetadata: Add getParentVolume
......................................................................


Patch Set 13:

(1 comment)

https://gerrit.ovirt.org/#/c/44042/13/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 559:         puuid = self.getParent()
Line 560:         if puuid and puuid != BLANK_UUID:
Line 561:             sd_manifest = sdCache.produce(self.sdUUID).manifest
Line 562:             return sd_manifest.produceVolume(self.imgUUID, puuid)
Line 563:         return None
> This is very ugly, I guess you are keeping the behavior of the Volume.getPa
Yes.  I cannot think of a better way to do this.  Can you?
Line 564: 
Line 565: 
Line 566: class Volume(object):
Line 567:     log = logging.getLogger('Storage.Volume')


-- 
To view, visit https://gerrit.ovirt.org/44042
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74def8861e0b7b97ca4d218a969440ccba7f07dd
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list