Change in vdsm[master]: jobs: Take lock once when deleting a job

nsoffer at redhat.com nsoffer at redhat.com
Tue Jan 5 16:37:08 UTC 2016


Nir Soffer has submitted this change and it was merged.

Change subject: jobs: Take lock once when deleting a job
......................................................................


jobs: Take lock once when deleting a job

Previous we use get() for checking if a job exists before deleting it,
and then check again in _delete. Move all the logic to _delete, so we
take the lock once and during this flow.

With this change, test coverage for this module is 100%.

Change-Id: If6dfb378820ab95cbafb16f0a8df8399f3b8285e
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/51215
Reviewed-by: Shahar Havivi <shavivi at redhat.com>
Reviewed-by: Adam Litke <alitke at redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani <fromani at redhat.com>
---
M lib/vdsm/jobs.py
1 file changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Adam Litke: Looks good to me, approved
  Nir Soffer: Verified
  Shahar Havivi: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/51215
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If6dfb378820ab95cbafb16f0a8df8399f3b8285e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list