Change in vdsm[master]: net: Enable VDSM to listen on IPv6 addresses

edwardh at redhat.com edwardh at redhat.com
Tue Jan 5 14:38:41 UTC 2016


Edward Haas has posted comments on this change.

Change subject: net: Enable VDSM to listen on IPv6 addresses
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/51319/2/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 359:         ('management_port', '54321',
Line 360:             'Port on which the vdsmd XMPRPC server listens to network '
Line 361:             'clients.'),
Line 362: 
Line 363:         ('management_ip', '::', 'Set to "0.0.0.0" to listen only on IPv4.'),
> is :: works for both v4 and v6 ? if so, why to set 0.0.0.0? if not, I think
'::' is for both.
Ok, I'll update the description.
Line 364: 
Line 365:         ('guests_gateway_ip', '', None),
Line 366: 
Line 367:         ('broker_address', '127.0.0.1',


https://gerrit.ovirt.org/#/c/51319/2/tests/protocoldetectorTests.py
File tests/protocoldetectorTests.py:

Line 136:         data = "echo testing is fun\n"
Line 137:         self.check_detect(use_ssl, data, data)
Line 138: 
Line 139:     @permutations(PERMUTATIONS)
Line 140:     def test_detect_echo6(self, use_ssl):
> call it test_detect_echo_ipv6 and change the one bellow to ..._ipv4
It's common to use this format, see ping6, tracepath6, etc..
All tests are IPv4 by default unless specified otherwise, marking all as IPv4 is a bit harsh.
Line 141:         self.start_acceptor(use_ssl, address='::1')
Line 142:         data = "echo testing is fun\n"
Line 143:         self.check_detect(use_ssl, data, data)
Line 144: 


-- 
To view, visit https://gerrit.ovirt.org/51319
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9c893d8f38f6abf183dcccbc2a5e328b492235e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list