Change in vdsm[master]: vm: extract cleanupRecoveryFile() helper

fromani at redhat.com fromani at redhat.com
Tue Jan 5 14:18:53 UTC 2016


Francesco Romani has uploaded a new change for review.

Change subject: vm: extract cleanupRecoveryFile() helper
......................................................................

vm: extract cleanupRecoveryFile() helper

This patch improves the code a tiny bit,
and makes it easier to implement the next patch, which wants
to fix a bug.

Change-Id: I28ff7c3d053842e3f735f3aa03eb579df579defe
Signed-off-by: Francesco Romani <fromani at redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/51386/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index d79f07b..9439969 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1695,7 +1695,7 @@
         self._cleanupDrives()
         self._cleanupFloppy()
         self._cleanupGuestAgent()
-        utils.rmFile(self._recoveryFile)
+        self._cleanupRecoveryFile()
         cleanup_guest_socket(self._qemuguestSocketFile)
         self._reattachHostDevices()
         self._cleanupStatsCache()
@@ -1703,6 +1703,9 @@
         for con in self._devices[hwclass.CONSOLE]:
             con.cleanup()
 
+    def _cleanupRecoveryFile(self):
+        utils.rmFile(self._recoveryFile)
+
     def _cleanupStatsCache(self):
         try:
             sampling.stats_cache.remove(self.id)


-- 
To view, visit https://gerrit.ovirt.org/51386
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I28ff7c3d053842e3f735f3aa03eb579df579defe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>


More information about the vdsm-patches mailing list