Change in vdsm[master]: guestagent: Speed up xml character filtering

nsoffer at redhat.com nsoffer at redhat.com
Tue Jan 5 11:20:02 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: guestagent: Speed up xml character filtering
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/50945/3/tests/guestagentTests.py
File tests/guestagentTests.py:

Line 89: @expandPermutations
Line 90: class TestFiltering(TestCaseBase):
Line 91: 
Line 92:     @permutations([
Line 93:         [u"\u0009-\u000a"],
> having a range here is very confusing. _filterXmlChars expects any unicode 
I can change the the test to generate all the unicode characters as we had before. Testing only the edge case was easier and seems good eough, so I chose the easier way.
Line 94:         [u"\u000d"],
Line 95:         [u"\u0020-\u007e"],
Line 96:         [u"\u0085"],
Line 97:         [u"\u00a0-\ud7ff"],


-- 
To view, visit https://gerrit.ovirt.org/50945
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7990dbe9787089b15f63e89de284c8695472b66
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list