Change in vdsm[ovirt-3.6]: fileSD: improve error handling in deleteImage

ybronhei at redhat.com ybronhei at redhat.com
Tue Jan 5 09:52:42 UTC 2016


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: fileSD: improve error handling in deleteImage
......................................................................


fileSD: improve error handling in deleteImage

In FileStorageDomainManifest.deleteImage, we used to log that the volume
could not be removed even if it was removed but the meta/lease file
could not be removed afterwards.

This patch logs more informative errors about the specific file that
could not be removed. If the removal fails because the file doesn't
exist, we log a warning. Otherwise, we log an error message that the
file can't be removed.

Also, if one of the files couldn't be removed, we didn't try to remove
the others.  Now we handle each removal separately, so that a failure in
the removal of one file doesn't affect the removal of the others.

This patch is a backport for patch
I9eeb28a70f708a4f9a5effe4ff294da63b757369 which was reverted.

Change-Id: I22ceee059cce1ec65cd455ce567cba0e49c00db2
Bug-Url: https://bugzilla.redhat.com/1292092
Signed-off-by: Idan Shaby <ishaby at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/51229
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/51299
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/storage/fileSD.py
1 file changed, 14 insertions(+), 13 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve
  Idan Shaby: Verified



-- 
To view, visit https://gerrit.ovirt.org/51299
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I22ceee059cce1ec65cd455ce567cba0e49c00db2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list