Change in vdsm[master]: guestagent: Speed up xml character filtering

danken at redhat.com danken at redhat.com
Tue Jan 5 09:15:30 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: guestagent: Speed up xml character filtering
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/50945/3/tests/guestagentTests.py
File tests/guestagentTests.py:

Line 93: -
having a range here is very confusing. _filterXmlChars expects any unicode string, and does not care about ranges.


https://gerrit.ovirt.org/#/c/50945/3/vdsm/virt/guestagent.py
File vdsm/virt/guestagent.py:

Line 2: 2014
silly, but its 2016 now.


-- 
To view, visit https://gerrit.ovirt.org/50945
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7990dbe9787089b15f63e89de284c8695472b66
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list