Change in vdsm[master]: constants: Define temporary volume indicators

nsoffer at redhat.com nsoffer at redhat.com
Mon Jan 4 17:14:09 UTC 2016


Nir Soffer has submitted this change and it was merged.

Change subject: constants: Define temporary volume indicators
......................................................................


constants: Define temporary volume indicators

This patch defines the file extension that identifies temporary
file-based volumes and the LV tag that identifies temporary block-based
volumes.  See below for details about why this will be needed.

Creating a volume requires multiple steps and many changes to storage
and the operation can fail at any point.  To make recovery from failure
at any point possible, we create volumes as temporary entities (called
VolumeArtifacts).  Once created, the VolumeArtifacts can be committed as
a new Volume with a single atomic operation.  For file-based volumes we
rename a file.  For block-based volumes we remove an LV tag.  If volume
creation fails at any point in the process, easily identifiable garbage
is left on storage which can be cleaned up automatically.

Change-Id: Id14e79d400d6936c8bb0da5dec39e3f9fb60c803
Signed-off-by: Adam Litke <alitke at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/49544
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Continuous-Integration: Jenkins CI
---
M vdsm/storage/constants.py
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Adam Litke: Verified
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/49544
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id14e79d400d6936c8bb0da5dec39e3f9fb60c803
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list