Change in vdsm[master]: net: mtu should be reported as a string through caps
nsoffer at redhat.com
nsoffer at redhat.com
Sun Jan 3 13:21:32 UTC 2016
Nir Soffer has posted comments on this change.
Change subject: net: mtu should be reported as a string through caps
......................................................................
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/51164/5/lib/vdsm/netinfo/__init__.py
File lib/vdsm/netinfo/__init__.py:
Line 104:
Line 105: return networking
Line 106:
Line 107:
Line 108: def get(vdsmnets=None, compatibility=None):
Lets make the default 30700
Line 109: if compatibility is None:
Line 110: return _get(vdsmnets)
Line 111: elif compatibility < 30700:
Line 112: # REQUIRED_FOR engine < 3.7
Line 105: return networking
Line 106:
Line 107:
Line 108: def get(vdsmnets=None, compatibility=None):
Line 109: if compatibility is None:
And now we can remove this branch.
Line 110: return _get(vdsmnets)
Line 111: elif compatibility < 30700:
Line 112: # REQUIRED_FOR engine < 3.7
Line 113: return _stringify_mtus(_get(vdsmnets))
--
To view, visit https://gerrit.ovirt.org/51164
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I719ed889bfae763ce7cbed4f2aab3f6134ba2865
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list