Change in vdsm[master]: net: mtu should be reported as a string through caps

nsoffer at redhat.com nsoffer at redhat.com
Sat Jan 2 11:54:56 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: net: mtu should be reported as a string through caps
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/51164/3/lib/vdsm/netinfo/__init__.py
File lib/vdsm/netinfo/__init__.py:

Line 97: 
Line 98:     return networking
Line 99: 
Line 100: 
Line 101: def get_with_engine36_compatibility():
> I don't like the compatibility logic to enter into the main method logic, t
This returns info from the netinfo module, so netinfo.get() is not that bad name. I think info() would be a better name, and also match other names (e.g. bonding.info())

But this patch is not about improving names but about restoring backward compatibility. Lets handle the name in another patch?
Line 102:     # REQUIRED_FOR engine < 3.7
Line 103:     return _stringify_mtus(get())
Line 104: 
Line 105: 


-- 
To view, visit https://gerrit.ovirt.org/51164
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I719ed889bfae763ce7cbed4f2aab3f6134ba2865
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list