Change in vdsm[master]: jsonrpcvdscli: improve functional network tests duration time

danken at redhat.com danken at redhat.com
Sat Jan 2 09:03:21 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: jsonrpcvdscli: improve functional network tests duration time
......................................................................


jsonrpcvdscli: improve functional network tests duration time

The tests were creating new jsonrpcvdscli#_Server every time before test
invocation. In __init__ method we perform schema parsing which is time
consuming operation. We improved duration time of the test by creating
the objects only once instead of before every test method.


Change-Id: Id1fd202566edd389f06d49876e5b83391686b53b
Signed-off-by: pkliczewski <piotr.kliczewski at gmail.com>
Reviewed-on: https://gerrit.ovirt.org/48356
Continuous-Integration: Jenkins CI
Reviewed-by: Ido Barkan <ibarkan at redhat.com>
Reviewed-by: Petr Horáček <phoracek at redhat.com>
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/functional/networkTests.py
M tests/functional/utils.py
2 files changed, 26 insertions(+), 5 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Nir Soffer: Looks good to me, but someone else must approve
  Ido Barkan: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Petr Horáček: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/48356
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id1fd202566edd389f06d49876e5b83391686b53b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list