Change in vdsm[master]: json: use forzenset for filtered methods

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Mon Feb 29 20:56:14 UTC 2016


Piotr Kliczewski has posted comments on this change.

Change subject: json: use forzenset for filtered methods
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/54160/1/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:

Line 468: 
Line 469: class JsonRpcServer(object):
Line 470:     log = logging.getLogger("jsonrpc.JsonRpcServer")
Line 471: 
Line 472:     filtered_methods = frozenset(['Host_getVMList', 'Host_getAllVmStats',
> This is a constant, so I think using uppercase would be good idea here.
Done
Line 473:                                   'Host_getStats', 'StorageDomain_getStats',
Line 474:                                   'VM_getStats', 'Host_fenceNode'])
Line 475: 
Line 476:     """


-- 
To view, visit https://gerrit.ovirt.org/54160
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I17becc319fb8e226f0badc883007900c8862a520
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list