Change in vdsm[master]: move alignmentScan.py to lib

nsoffer at redhat.com nsoffer at redhat.com
Mon Feb 29 20:41:10 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: move alignmentScan.py to lib
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/53758/6/tests/alignmentScanTests.py
File tests/alignmentScanTests.py:

Line 24: from nose.tools import eq_, raises
Line 25: from nose.plugins.skip import SkipTest
Line 26: from testlib import VdsmTestCase as TestCaseBase
Line 27: from testValidation import brokentest, slowtest
Line 28: from vdsm.commands import execCmd
Please keep using misc.execCmd - this changes the logging and may break our debugging tools depending on vdsm log.

Looks like storage.misc must move first to lib - and alignmentScan should move into lib/vdsm/storage - this is not common infrastructure.
Line 29: from vdsm.alignmentScan import runScanArgs, scanImage, VirtAlignError
Line 30: 
Line 31: 
Line 32: def mkimage(imagepath, aligned=True):


-- 
To view, visit https://gerrit.ovirt.org/53758
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0537393da342507c9e64e9d71656cfc69bbe15e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list