Change in vdsm[ovirt-3.6]: net: use the correct dict with all the networks for disable_...

danken at redhat.com danken at redhat.com
Mon Feb 29 17:18:36 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: net: use the correct dict with all the networks for disable_ipv6 restoration
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/53942/2/vdsm/vdsm-restore-net-config
File vdsm/vdsm-restore-net-config:

Line 140: available_config
> I am afraid I don't follow, again. How would new bridges come to existence 
new bridges can pop up if (for some reason) initscripts failed to create them on time. _filter_changed_nets_bonds() would include them, and and ask setupNetworks to create them.

HOWEVER, I have to correct myself: the setupNetwork flow is expected to turn ipv6 off (due to another few months old patch by Ondra).

Still, this patch needs a fix: we do to touch ONLY the available networks, and BEFORE _filter_change_nets_bonds() is caused. We need to drop ipv6 from initscripts-created networks (not only bridges, but also other top-level devices) prior to the comparison.


-- 
To view, visit https://gerrit.ovirt.org/53942
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If49f549d91c54cb7b3c31a23436008dc1c622682
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list