Change in vdsm[master]: numa: move cpu topology (numa) related functionality to sitelib

fromani at redhat.com fromani at redhat.com
Mon Feb 29 16:57:04 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: numa: move cpu topology (numa) related functionality to sitelib
......................................................................


Patch Set 8: Code-Review+2

(1 comment)

looks fine, but pretty please read inside comments :)

https://gerrit.ovirt.org/#/c/53287/8/lib/vdsm/numa.py
File lib/vdsm/numa.py:

Line 102:         'sockets': len(sockets),
Line 103:         'cores': len(siblings),
Line 104:         'threads': len(online_cpus),
Line 105:         'onlineCpus': online_cpus,
Line 106:     }
Can we have a namedtuple? :)
I find

  topology.sockets

so much nicer than

  topology["sockets"]

I guess the return value should not be mutable, does it?
Line 107: 


-- 
To view, visit https://gerrit.ovirt.org/53287
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie786e8a3626dd257c2a244decfe3e6a127d04b28
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list