Change in vdsm[master]: virt: Add `vm' argument to underlying_device_info methods

fromani at redhat.com fromani at redhat.com
Mon Feb 29 16:24:52 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: virt: Add `vm' argument to underlying_device_info methods
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/53676/1//COMMIT_MSG
Commit Message:

Line 11: instead of adding more other arguments.  Perhaps we could remove some of
Line 12: the other underlying_device_info arguments when we've got `vm'.  Perhaps
Line 13: we should take a different approach.  It's for discussion, but for now
Line 14: we take this path to make storage device handling movable out of Vm
Line 15: class.
> Since we are going to make `domain' publicly accessible from Vm in another 
In general I don't think it is a good idea.

Unfortunately, we are kinda constrained from the existing code and architecture. So we either redesign this flow from scratch, which is unlikely although everyone agrees that would be the best move, or we go on incrementally. If we go on incrementally, I'm persuaded we don't have other concrete options.
Line 16: 
Line 17: Change-Id: Ide9e8d105d6c14101f9ce367409af729a075b2df


-- 
To view, visit https://gerrit.ovirt.org/53676
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide9e8d105d6c14101f9ce367409af729a075b2df
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list