Change in vdsm[master]: net: rename destroyOnMasterRemoval

danken at redhat.com danken at redhat.com
Mon Feb 29 12:48:19 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: rename destroyOnMasterRemoval
......................................................................


net: rename destroyOnMasterRemoval

destroyOnMasterRemoval parameter was needed to say whether bonding
should be removed together with network (implicit bonding) or just
detached. Now when we drop implicit bonding, we can change it's logic
to something more understandable.

With this patch, destroyOnMasterRemoval was renamed to
on_removal_just_detach_from_network. It's extremely long, but verbosity
is needed here.

Default functionality of bond.remove() is evidently removal, so
this new parameter is False by default.

When a bonding is objectivized as a part of a network, we need it
to be just detached from master, set it default MTU etc, so it
will be a standalone bonding again. When we objectivize it as a
part of bonding query, then by bond.remove() we really mean the
removal.

Change-Id: I0ca4ba568c3f24b20a5e9ee70b3f6935bbc22eab
Signed-off-by: Petr Horáček <phoracek at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/54082
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/network/api.py
M lib/vdsm/network/configurators/ifcfg.py
M lib/vdsm/network/configurators/iproute2.py
M lib/vdsm/network/models.py
4 files changed, 27 insertions(+), 29 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/54082
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0ca4ba568c3f24b20a5e9ee70b3f6935bbc22eab
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list