Change in vdsm[master]: gluster: Don't fail connect server when getting volume info

ahino at redhat.com ahino at redhat.com
Mon Feb 29 12:44:04 UTC 2016


Ala Hino has posted comments on this change.

Change subject: gluster: Don't fail connect server when getting volume info
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/53785/4/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:

Line 347:                              "servers")
Line 348:             return
Line 349: 
Line 350:         if self.volinfo is None:
Line 351:             return
> I think the flow is:
This return does not disable the entire flow, it only "breaks" the validate method. Anyway, I will change it to id self.volinfo is not None and add the validation block inside the if. This way, we don't break future validation that are not related to volinfo.

Regarding the backup servers, we still have this feature even if volinfo is None. In 'options' property we first check whether user provide the backup option and if so we use it. If not, we try to get the servers using volinfo.
Line 352: 
Line 353:         replicaCount = self.volinfo['replicaCount']
Line 354:         if replicaCount not in self.ALLOWED_REPLICA_COUNTS:
Line 355:             self.log.warning("Unsupported replica count (%s) for volume %r, "


-- 
To view, visit https://gerrit.ovirt.org/53785
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e1835b7de4c5c4c5c4616d3c36f15c1f91a01dc
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list