Change in vdsm[master]: net: api: drop connectivity_check_networks

danken at redhat.com danken at redhat.com
Mon Feb 29 12:35:15 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: api: drop connectivity_check_networks
......................................................................


net: api: drop connectivity_check_networks

It is not needed anymore to explicitly remove networks after failed
connectivity check, it used to be required only by implicit bondings.

Now the whole removal is handled by rollback.

New test testSetupNetworksConnectivityCheckOverExistingBond() was
introduced to test if the removed code is not needed anymore:
  # If the new added network was created on top of
  # existing bond, we need to keep the bond on rollback
  # flow, else we will break the new created bond.

With this patch testSetupNetworksConnectivityCheck() works as a
test for previous patch 5780914a98f208e70d7050e78a330ab13425639d.

Change-Id: I7bbfe2705c7165381a353d7d3effb493a1738631
Signed-off-by: Petr Horáček <phoracek at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/54070
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/network/api.py
M tests/functional/networkTests.py
2 files changed, 25 insertions(+), 15 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/54070
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7bbfe2705c7165381a353d7d3effb493a1738631
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list