Change in vdsm[master]: virt: Move Vm._getUnderlyingDriveInfo() out of Vm

fromani at redhat.com fromani at redhat.com
Mon Feb 29 11:26:33 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
......................................................................


Patch Set 7: Code-Review+1

(1 comment)

partial ACK because of one inline question (but looks good overall)

https://gerrit.ovirt.org/#/c/53677/7/tests/devices/data/testComplexVm.xml
File tests/devices/data/testComplexVm.xml:

Line 142:       <backend model='random'>/dev/random</backend>
Line 143:       <alias name='rng1'/>
Line 144:       <address type='pci' domain='0x0000' bus='0x00' slot='0x0a' function='0x0'/>
Line 145:     </rng>
Line 146:     <disk device="cdrom" snapshot="no" type="file">
Could you please remind me why this is needed?
Line 147:       <address bus="1" controller="0" target="0" type="drive" unit="0"/>
Line 148:       <source file="" startupPolicy="optional"/>
Line 149:       <target bus="ide" dev="hdc"/>
Line 150:       <readonly/>


-- 
To view, visit https://gerrit.ovirt.org/53677
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6b372f86b82da7422727f3d084b9afc5505a289
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list