Change in vdsm[master]: virt: Move Vm._getUnderlyingSoundDeviceInfo() out of Vm

fromani at redhat.com fromani at redhat.com
Mon Feb 29 11:10:58 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: virt: Move Vm._getUnderlyingSoundDeviceInfo() out of Vm
......................................................................


Patch Set 6: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/53616/6/vdsm/virt/vmdevices/core.py
File vdsm/virt/vmdevices/core.py:

Line 232:         sound = self.createXmlElem('sound', None, ['address'])
Line 233:         sound.setAttrs(model=self.device)
Line 234:         return sound
Line 235: 
Line 236:     @classmethod
You argument for classmethod was convincing enough. Let's go this way.
Line 237:     def update_device_info(cls, vm):
Line 238:         for x in vm.domain.get_device_elements('sound'):
Line 239:             alias = x.getElementsByTagName('alias')[0].getAttribute('name')
Line 240:             # Get sound card address


-- 
To view, visit https://gerrit.ovirt.org/53616
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05cb24e0a9776e21bd2546d62a56554d74559c61
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list