Change in vdsm[master]: repoplot: Prepare for matching multiple patterns

fromani at redhat.com fromani at redhat.com
Mon Feb 29 10:02:52 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: repoplot: Prepare for matching multiple patterns
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/54013/2/contrib/repoplot
File contrib/repoplot:

Line 103:     """
Line 104:     Add repostats samples from repoStats response line
Line 105:     """
Line 106:     timestamp = parse_timestamp(line)
Line 107:     response = eval(line[end:])
I don't like eval in general, but here seems OK and I can't think of a better alternative.
Line 108:     for uuid, info in response.items():
Line 109:         ds = stats[uuid]
Line 110:         ds.timestamp.append(timestamp)
Line 111:         ds.lastcheck.append(float(info["lastCheck"]))


-- 
To view, visit https://gerrit.ovirt.org/54013
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id0fbf7bfdf73d0f8088afe459124272782396ede
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list