Change in vdsm[master]: tests: virt: modernize vm* tests

fromani at redhat.com fromani at redhat.com
Mon Feb 29 08:24:37 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: tests: virt: modernize vm* tests
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/54022/2/tests/vmApiTests.py
File tests/vmApiTests.py:

Line 51: list
> Done
Sorry, hit "sent" too early.
We need a list for py3 because:

1003 09:23:45 fromani at musashi ~ $ python3
Python 3.4.3 (default, Jun 29 2015, 12:16:01) 
[GCC 5.1.1 20150618 (Red Hat 5.1.1-4)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> d = {'a':3}
>>> d.values()[0]
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: 'dict_values' object does not support indexing


-- 
To view, visit https://gerrit.ovirt.org/54022
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9324ef9d17df148ea38a03771b896132ec02e22
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list